Add first kotlintoolchain version#776
Merged
Merged
Conversation
17222f4 to
76bc2f3
Compare
marc0der
approved these changes
May 19, 2026
Contributor
There was a problem hiding this comment.
Reviewed the migration end-to-end against the patterns used elsewhere in the repo (BallerinaMigrations, KobwebMigrations, etc.) and against package.scala's validation rules.
What's correct
- Order/id wiring —
order = "002"cleanly follows001; id002_add_kotlintoolchain_0_11_0matches theNNN_add_<candidate>_<version>convention used across other candidates, and the author is consistent with001. - Candidate reference —
candidate = "kotlintoolchain"matches the candidate inserted inmigration001. - Version length —
"0.11.0"(6 chars) is well under the 15-char ceiling enforced byversionValidation.validVersioninpackage.scala. - URL —
https://packages.jetbrains.team/.../kotlin-cli-sdkman-0.11.0.zipresolves withHTTP/2 200(13,158 bytes), so.validate()will succeed at migration time. - Platform default — relying on
Universal(default) is consistent with thedistribution = "UNIVERSAL"set on the candidate inmigration001, and matches how other UNIVERSAL candidates (e.g. Kobweb when they add their first version) are wired. .asCandidateDefault()— required for the first version; without itcandidates.defaultwould stayNoneand the CLI wouldn't have a default to install. Correct here.- CI —
buildjob is green.
Nits (non-blocking)
- Tiny style drift:
migration001isdef migration001(implicit db: MongoDatabase) =whilemigration002isdef migration002(implicit db: MongoDatabase): Unit =. Both forms exist across the codebase, so not worth churning — just flagging. - Some files (e.g.
BallerinaMigrations) extractprivate val CandidateName = "kotlintoolchain"to avoid repeating the string. Optional; the file is small enough that inline is fine.
LGTM — first version is correctly wired and validated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.