Clean up RuboCop config deprecation warnings#652
Closed
wilfison wants to merge 2 commits into
Closed
Conversation
The cop has been renamed to `Naming/PredicatePrefix` in v1.76.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small
.rubocop.ymlupdates that remove deprecation warnings printed on every RuboCop run.1. Use
pluginsinstead ofrequirefor rubocop-performanceLoads
rubocop-performancevia theplugins:key instead ofrequire:.Since RuboCop 1.72, extensions that support the plugin API (such as
rubocop-performance) are expected to be declared underplugins:. Keeping it underrequire:prints:2. Rename
Naming/PredicateNametoNaming/PredicatePrefixUpdates the cop name to its current spelling.
The cop was renamed in RuboCop, so the old name triggers:
Scope
Both changes only affect the development environment.