Skip to content
This repository was archived by the owner on Sep 9, 2025. It is now read-only.

Conversation

@vancauwe
Copy link
Contributor

Agilent:

  • fix peak property

Synth:

  • fix property reference (instead of property shape) and remove legacy term speedInRPM

Synth, Agilent, Bravo:

  • Uniforming product reference
  • URI for Product across files for easier queries and easier future matching to result identifier from Cat+ system (the identity of the product)

@vancauwe vancauwe requested review from cmdoret and sabinem June 23, 2025 15:38
@vancauwe vancauwe self-assigned this Jun 23, 2025
@vancauwe vancauwe added bug Something isn't working enhancement New feature or request labels Jun 23, 2025
Copy link
Member

@cmdoret cmdoret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have one suggestion to reduce duplication, besides that, it all looks good :)

Copy link
Member

@cmdoret cmdoret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect ✨

@sabinem sabinem removed their request for review June 30, 2025 08:53
@vancauwe vancauwe merged commit 5f2b38f into main Jun 30, 2025
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants