ci(docker): fix release tag#145
Merged
Merged
Conversation
cmdoret
commented
Jun 13, 2025
cmdoret
commented
Member
- Fixes tag extraction in docker publish CI workflow
- Bumps the tag of the base layer for the server image
almutlue
approved these changes
Jun 16, 2025
almutlue
left a comment
almutlue
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot! 👍
Question: It is easy to forget bumping the version in modos-server. It would be nice to have some ci/test that checks compatibility e.g. upon changes in `server.py similar? Shall we open a low priority issue?
Member
Author
|
Good point, I've opened #149 to track it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.