-
Notifications
You must be signed in to change notification settings - Fork 40
Clip Video #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Clip Video #177
Conversation
|
@YosieSYX Did you create these videos yourself? |
|
Hi professor Damith, the videos were obtained from VSCode documentation page. However, as I need to crop some of the videos to better suit the content, I downloaded the videos and cropped them. |
|
@YosieSYX Just wondering, is it possible to use the same video but specify start and end times, as done in https://se-education.org/guides/tutorials/intellijDebugger.html ? |
|
Hi Prof, thank you for your suggestion. I do see the value in it, but I feel that simply displaying the video might work better than having the students trace the timings themselves. |
@YosieSYX Students don't need to trace the timings. The video player automatically plays the correct segment of the video. |
tutorials/vscRefactoring.md
Outdated
| "https://code.visualstudio.com/assets/docs/java/java-refactoring/refactor.mp4", | ||
| 0, | ||
| 17 | ||
| ) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YosieSYX I tried this on my Mac/Safari, and this one did not stop at 17s mark.
402fee9 to
f224a0e
Compare
|
Hi prof sorry I had to revert to the previous commit. I just realised that for these type of in browser videos it is hard to let it stop at a specific time like the youtube videos and I don't have a good way of doing it now. The previous method does not really work. |
fix #160