Fixes for crates/sel4 and crates/sel4-capdl-initializer - #278
Merged
Conversation
dreamliner787-9
changed the title
dreamliner787-9
force-pushed
the
capdl-vmattr-fix
branch
from
August 5, 2025 01:25
ffdc48f to
fda5c3e
Compare
dreamliner787-9
force-pushed
the
capdl-vmattr-fix
branch
2 times, most recently
from
August 5, 2025 03:05
dedcc07 to
9985cf8
Compare
dreamliner787-9
added a commit
to au-ts/microkit
that referenced
this pull request
Aug 14, 2025
…ed on PR seL4/rust-sel4#278 Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>
nspin
reviewed
Aug 22, 2025
nspin
left a comment
nspin
left a comment
Member
There was a problem hiding this comment.
This all looks great, thank you for these fixes.
Sorry it's taken me a little while to get around to reviewing them.
See comments above.
This wasn't a problem on QEMU. But on physical platform, R/W to device memory will cause seL4 to halt. Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>
Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>
dreamliner787-9
force-pushed
the
capdl-vmattr-fix
branch
from
August 25, 2025 03:13
9985cf8 to
6fe6e14
Compare
Contributor
Author
|
Hi Nick, thank you for your review. I've fixed all the issues you highlighted. Please let me know what you think. |
nspin
requested changes
Aug 31, 2025
nspin
left a comment
nspin
left a comment
Member
There was a problem hiding this comment.
Looks great, thanks.
I added one more comment for a change I missed in my first review. After that change we'll merge.
This works by creating a "fake" ARM SMC object, which is assigned the initial thread's SMC cap. Then we can mint it to any CSpace just like other object types. Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>
Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>
Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>
Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>
Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>
Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>
Signed-off-by: Bill Nguyen <bill.nguyen@student.unsw.edu.au>
dreamliner787-9
force-pushed
the
capdl-vmattr-fix
branch
from
September 1, 2025 00:38
6fe6e14 to
aa0c832
Compare
nspin
approved these changes
Sep 1, 2025
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crates/sel4:
crates/sel4-capdl-initializer: