Skip to content

ci(github): handle CRLF PR template bodies - #227

Merged
seakee merged 1 commit into
mainfrom
ci/pr-template-crlf
Jun 23, 2026
Merged

seakee merged 1 commit into
mainfrom
ci/pr-template-crlf

Conversation

@seakee

@seakee seakee commented Jun 23, 2026

Copy link
Copy Markdown
Owner

Summary

Normalize PR body line endings before validating the pull request template.
This fixes false PR Template failures when GitHub event payloads contain CRLF line endings.

Scope

  • Frontend panel
  • Manager Server
  • CPA panel mode
  • Full Docker mode
  • Native packages / release
  • Docs / Wiki
  • CI / build / tooling

Changes

  • Remove carriage-return characters from PR_BODY before header and Scope checks.
  • Keep the existing required-section and checked-Scope validation unchanged.
  • Fix CRLF PR descriptions that already contain a valid checked Scope item.

User Impact

No user-facing behavior change.

Compatibility / Runtime Notes

  • CPA panel mode: N/A
  • Manager Server mode: N/A
  • Full Docker / native packages: N/A

Data / Security Notes

N/A

Risk / Rollback

Risk level: Low

Rollback notes:

  • Revert this workflow-only change to restore the previous PR body validation behavior.

Verification

  • Type check
  • Lint
  • Tests
  • Build
  • Manual UI check
  • Docs/link check
  • Not applicable, docs-only

Commands / evidence:

CRLF PR body fixture passes the same Scope checkbox grep after normalization.

Screenshots / Recordings

N/A

Docs

  • README updated
  • Wiki updated
  • Release notes needed
  • Not needed

Related

Refs #225

Normalize PR body line endings before validating template content.

This prevents checked Scope items from failing the GitHub Actions regex when the pull request body contains CRLF line endings from the GitHub event payload.

Low risk: the workflow still checks the same required sections and Scope items.
@seakee
seakee merged commit cea3114 into main Jun 23, 2026
4 checks passed
@seakee
seakee deleted the ci/pr-template-crlf branch June 23, 2026 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant