feat(web): normalize plugin OAuth provider id - #241
Merged
Merged
Conversation
Honors an explicit oauth_provider field on the plugin manifest so plugins can register a custom OAuth key without colliding with the built-in provider ids. The legacy fallback to the plugin id is gated on the field being absent, so plugins that already publish a custom oauth_provider are not silently overridden. A small helper centralizes the resolution and the visibility rule for the OAuth page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize plugin OAuth provider ids in the web panel so plugins can publish an explicit OAuth provider key without colliding with built-in providers.
Keep legacy behavior for plugins that support OAuth but do not provide an explicit provider id.
Scope
Changes
oauth_provider/oauthProvider.User Impact
Plugins can register custom OAuth provider ids without being forced to use the plugin id in the OAuth login flow.
Compatibility / Runtime Notes
Data / Security Notes
N/A
Risk / Rollback
Risk level: Low
Rollback notes:
Verification
Commands / evidence:
Screenshots / Recordings
N/A
Docs
Related
N/A