ci(release): enforce external contributor acknowledgements - #775
Merged
Merged
Conversation
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make external contributor acknowledgements a fail-closed part of release-content validation so a release cannot omit contributors that actually shipped.
Scope
Changes
bin/release/validate-release-contributors.mjsto resolve first-parent integration merges between the previous release tag and the frozen release-sourcedevSHA, map those merges to merged PR metadata, and collect external PR authors while excluding the repository owner and bots.Acknowledgementssections and in Telegram GitHub profile links.dev; promotion PRs continue to validate the release files without repeating contributor discovery.Release Contentjob onlycontents: readandpull-requests: readpermissions for this check.User Impact
No runtime behavior changes. Future releases with external contributors will fail
Release Contentif the contributor set is missing, incomplete, duplicated, or inconsistent across formal release notes and the Telegram source post.Compatibility / Runtime Notes
GITHUB_TOKENwith read-only PR access.Data / Security Notes
The new GitHub API access is read-only. No contributor metadata is persisted outside normal CI logs, and no write permission is added to the validation job.
Risk / Rollback
Risk level: Low to Medium. The change intentionally makes release preparation stricter; a contributor-resolution bug could block a release PR but cannot mutate release state.
Rollback by reverting this PR to restore the previous release-content validation behavior.
Verification
Commands / evidence:
devtargeting, and frozen base SHA usage.Screenshots / Recordings
N/A — CI/release-process behavior only.
Docs
Docs decision: release-process behavior is encoded in the validator/workflow contract; no end-user product documentation changes are required.
Related
Refs #742
Refs #746
Refs #773