Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace committed binary with GitHub actions workflow #18

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Replace committed binary with GitHub actions workflow #18

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85ff7eb
Gopkg.toml: Set seamia/tools to version v1.1.8, not master branch
shasheene Nov 2, 2024
3326038
Delete precompiled binaries commited in repo
shasheene Nov 2, 2024
4e20b36
actions: Build on GA upon push
shasheene Nov 2, 2024
4fceca4
actions: Upload git artifacts (on push) and assets (on tag)
shasheene Nov 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/build-and-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,27 @@ jobs:
env:
GOOS: ${{ matrix.go-os-target }}
GOARCH: ${{ matrix.go-arch-target }}


- name: Upload built assets (on tag push)
uses: softprops/action-gh-release@v2
if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
with:
files: build/*

# Upload GitHub Action workflow *artifacts*. Note "artifacts" are a different concept to GitHub release assets.
# The former is available on each GitHub Actions workflow run. The latter is associated with only a pushed tag.

- name: Upload release artifacts except Windows
uses: actions/upload-artifact@v4
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops I lost the following line that's supposed to be here

        if: matrix.go-os-target != 'windows'

with:
name: "protodot-${{ matrix.go-os-target }}-${{ matrix.go-arch-target }}"
path: "build/protodot-${{ matrix.go-os-target }}-${{ matrix.go-arch-target }}"

# Ensure Windows assets have exe extension
- name: Upload remaining Windows release artifacts (with 'exe' extension)
uses: actions/upload-artifact@v3
if: matrix.go-os-target == 'windows'
with:
name: "protodot-${{ matrix.go-os-target }}-${{ matrix.go-arch-target }}.exe"
path: "build/protodot-${{ matrix.go-os-target }}-${{ matrix.go-arch-target }}.exe"