feat(config): add allow unresolved types and decouple show missing types#22
Open
jonfitt wants to merge 2 commits intoseamia:masterfrom
Open
feat(config): add allow unresolved types and decouple show missing types#22jonfitt wants to merge 2 commits intoseamia:masterfrom
jonfitt wants to merge 2 commits intoseamia:masterfrom
Conversation
- Add optionBoolDefault for allow unresolved types (defaults to true when key missing) - Panic on unresolved field types when allow unresolved types is false - Show missing types only affects DOT output; register placeholders when unresolved types are allowed - Document new option in config.json
- Add optionBoolDefault and allow unresolved types; strict panic when false - Decouple show missing types from resolution; omit missing nodes and edges when false - Close .dot writers before invoking graphviz (Windows file lock) - Write SVG/PNG from dot stdout only so Pango warnings do not corrupt XML - Default node font to Arial for cross-platform availability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• allow unresolved types (default true, omittable) — when false, fail fast on unresolved field/RPC types; when true, same behavior as before with synthetic
missing types.
• show missing types — only controls whether missing-type nodes/edges are emitted in the DOT graph; no longer affects whether resolution runs.
• optionBoolDefault in config.go so a missing allow unresolved types key defaults to permissive (backward compatible).