Skip to content

Impl From<async_impl::Client> for blocking::Client - #3024

Open
NobodyXu wants to merge 15 commits into
seanmonstar:masterfrom
NobodyXu:patch-2
Open

Impl From<async_impl::Client> for blocking::Client#3024
NobodyXu wants to merge 15 commits into
seanmonstar:masterfrom
NobodyXu:patch-2

Conversation

@NobodyXu

@NobodyXu NobodyXu commented May 4, 2026

Copy link
Copy Markdown
Contributor

@NobodyXu
NobodyXu marked this pull request as ready for review May 4, 2026 17:19
@NobodyXu

NobodyXu commented May 4, 2026

Copy link
Copy Markdown
Contributor Author

Msrv failed because I use tokio::task::id() during logging, which is available on tokio v1.41.0 with msrv 1.70

if I stop logging task id then we can keep the existing msrv

@NobodyXu

NobodyXu commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

cc @seanmonstar

@NobodyXu

Copy link
Copy Markdown
Contributor Author

Msrv is fixed, but windows CI failure seems to be flaky, just need a retry

@NobodyXu

Copy link
Copy Markdown
Contributor Author

CI is now Green, cc @seanmonstar

@NobodyXu
NobodyXu force-pushed the patch-2 branch 3 times, most recently from 3df5778 to f2d8295 Compare June 25, 2026 13:22
@NobodyXu

Copy link
Copy Markdown
Contributor Author

Pinging @seanmonstar, this PR will be useful for sharing async clients with blocking libraries, like gix

@NobodyXu

NobodyXu commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

CI failure is flaky due to network, a retry should fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant