refactor(middleware): handle URI parsing safely in cookie and redirect services - #3088
Open
spellsaif wants to merge 1 commit into
Open
refactor(middleware): handle URI parsing safely in cookie and redirect services#3088spellsaif wants to merge 1 commit into
spellsaif wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safely handle
http::Uritoreqwest::Urlparsing inCookieServiceandTowerRedirectPolicy, eliminating potential.expect()panic sites on invalid or relative URIs.Motivation & Problem
CookieServiceandTowerRedirectPolicyused.expect("invalid URL")when convertingreq.uri()or redirect previous targets. If custom Tower stacks pass origin-form or relative URIs (e.g./api/v1/resource),Url::parsereturnsErr(RelativeUrlWithoutBase), causing an unexpected library panic.Solution
CookieService: Safely convertreq.uri()with.ok(). Ifreq.uri()is relative, gracefully skip cookie header insertion and cookie response extraction for that request without panicking.TowerRedirectPolicy: ReturnErr(crate::error::builder(e))instead of panicking on invalid URLs.Testing
cargo check --features cookiespasses cleanly.