Move to minimum working hyper util#1128
Merged
seanmonstar merged 1 commit intoseanmonstar:masterfrom Aug 7, 2025
Merged
Conversation
If hyper-util 0.1.11 is in the build tree then you get the following
error:
```
error[E0599]: no method named `watcher` found for struct `GracefulShutdown` in the current scope
--> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/warp-0.4.1/src/server.rs:368:45
|
368 | let watcher = graceful_util.watcher();
| ^^^^^^^
|
help: there is a method `watch` with a similar name, but with different arguments
--> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/hyper-util-0.1.11/src/server/graceful.rs:32:5
|
32 | pub fn watch<C: GracefulConnection>(&self, conn: C) -> impl Future<Output = C::Output> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
For more information about this error, try `rustc --explain E0599`.
error: could not compile `warp` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
Error: Process completed with exit code 101.
```
This goes away with hyper-util 0.1.12 so I've set that in the manifest
so if a suer is on an earlier version it'll upgrade (and not impact
anyone on a newer version)
Contributor
Author
|
I can also just set it to the latest hyper util but I figured I'd be a bit more cautious in case there was an MSRV change or something unexpected |
seanmonstar
approved these changes
Aug 7, 2025
Contributor
|
error[E0432]: unresolved import `http_body_util::BodyDataStream`
--> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/warp-0.4.0/src/filters/body.rs:14:5
|
14 | use http_body_util::BodyDataStream;
| ^^^^^^^^^^^^^^^^--------------
| | |
| | help: a similar name exists in the module: `BodyStream`
| no `BodyDataStream` in the root |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If hyper-util 0.1.11 is in the build tree then you get the following error:
This goes away with hyper-util 0.1.12 so I've set that in the manifest so if a suer is on an earlier version it'll upgrade (and not impact anyone on a newer version)