Skip to content

Move to minimum working hyper util#1128

Merged
seanmonstar merged 1 commit intoseanmonstar:masterfrom
xd009642:fix-hyper-util
Aug 7, 2025
Merged

Move to minimum working hyper util#1128
seanmonstar merged 1 commit intoseanmonstar:masterfrom
xd009642:fix-hyper-util

Conversation

@xd009642
Copy link
Contributor

@xd009642 xd009642 commented Aug 7, 2025

If hyper-util 0.1.11 is in the build tree then you get the following error:

error[E0599]: no method named `watcher` found for struct `GracefulShutdown` in the current scope
   --> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/warp-0.4.1/src/server.rs:368:45
    |
368 |                 let watcher = graceful_util.watcher();
    |                                             ^^^^^^^
    |
help: there is a method `watch` with a similar name, but with different arguments
   --> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/hyper-util-0.1.11/src/server/graceful.rs:32:5
    |
32  |     pub fn watch<C: GracefulConnection>(&self, conn: C) -> impl Future<Output = C::Output> {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0599`.
error: could not compile `warp` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
Error: Process completed with exit code 101.

This goes away with hyper-util 0.1.12 so I've set that in the manifest so if a suer is on an earlier version it'll upgrade (and not impact anyone on a newer version)

If hyper-util 0.1.11 is in the build tree then you get the following
error:

```
error[E0599]: no method named `watcher` found for struct `GracefulShutdown` in the current scope
   --> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/warp-0.4.1/src/server.rs:368:45
    |
368 |                 let watcher = graceful_util.watcher();
    |                                             ^^^^^^^
    |
help: there is a method `watch` with a similar name, but with different arguments
   --> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/hyper-util-0.1.11/src/server/graceful.rs:32:5
    |
32  |     pub fn watch<C: GracefulConnection>(&self, conn: C) -> impl Future<Output = C::Output> {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0599`.
error: could not compile `warp` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
Error: Process completed with exit code 101.
```

This goes away with hyper-util 0.1.12 so I've set that in the manifest
so if a suer is on an earlier version it'll upgrade (and not impact
anyone on a newer version)
@xd009642
Copy link
Contributor Author

xd009642 commented Aug 7, 2025

I can also just set it to the latest hyper util but I figured I'd be a bit more cautious in case there was an MSRV change or something unexpected

@seanmonstar seanmonstar merged commit e5001e2 into seanmonstar:master Aug 7, 2025
10 checks passed
@tyranron
Copy link
Contributor

tyranron commented Aug 7, 2025

http-body-util should also be bumped to 0.1.2, because:

 error[E0432]: unresolved import `http_body_util::BodyDataStream`
  --> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/warp-0.4.0/src/filters/body.rs:14:5
   |
14 | use http_body_util::BodyDataStream;
   |     ^^^^^^^^^^^^^^^^--------------
   |     |               |
   |     |               help: a similar name exists in the module: `BodyStream`
   |     no `BodyDataStream` in the root

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants