Fix broken Makefile REGRESS list and CI package conflict - #71
Merged
Conversation
Two problems were leaving main red / unbuildable: 1. Merging PRs #68, #69 and #70 mis-resolved the REGRESS list. A missing line-continuation backslash after semaphore_validation left schema_install dangling, which made `make` itself fail with "missing separator", and the six subsystem tests added in #68 (free_memory, signals, ipc, semaphore_wait, scheduler, power) were dropped from the list even though their sql/ and expected/ files were committed. Rebuild the list with every test (21 total) and correct continuations. `make installcheck` is green again. 2. The CI workflow installed postgresql-server-dev-all, whose dependency on the archive's postgresql-common conflicts with the newer PGDG postgresql-common already present on the runner image, so the install step aborted before any test ran. Install versioned PGDG packages (postgresql-16 + postgresql-server-dev-16), detect the cluster's actual port, and pin PG_CONFIG so build, install and installcheck all target the same server. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ty3Rkif9Vfe95w8TMiKB4b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two problems are currently leaving
mainunbuildable and CI red.1. Mangled
REGRESSlist (merge fallout)Merging #68, #69 and #70 mis-resolved the
REGRESSlist in theMakefile:\aftersemaphore_validationleftschema_installdangling, somakeitself fails withMakefile:18: *** missing separator.free_memory,signals,ipc,semaphore_wait,scheduler,power) were dropped from the list, even though theirsql/andexpected/files are committed — so they silently stopped running.Rebuilt the list with every test (21 total) and correct continuations.
make installcheck→ All 21 tests passed locally.2. CI install step aborts on a package conflict
The workflow installed
postgresql-server-dev-all, whose dependency on the archive'spostgresql-commonconflicts with the newer PGDGpostgresql-commonalready present on the runner image:So the job died in ~10s, before any test ran. Now it installs versioned PGDG packages (
postgresql-16+postgresql-server-dev-16), detects the cluster's actual port, and pinsPG_CONFIGso build/install/test all target the same server.Validation
makeparses andmake installcheckpasses all 21 tests locally.make PG_CONFIG=… installcheckinvocation were validated locally. The apt resolution and runner-role steps can only be confirmed on the GitHub runner — this PR's own CI run is the check for that.🤖 Generated with Claude Code
Generated by Claude Code