feat: 🎸 rename size tokens; add icon ui#172
Open
zhixinbao wants to merge 1 commit intosearchfe:mainfrom
Open
Conversation
Sheetaa
reviewed
Apr 22, 2022
| line-height: 0; | ||
| text-align: center; | ||
| text-transform: none; | ||
| text-rendering: optimizeLegibility; |
Contributor
There was a problem hiding this comment.
这个属性在图标这儿的作用是啥？我看文档说这个属性可能会有性能问题
Author
There was a problem hiding this comment.
参考了semi-icons，没怎么深究，不合适可以去掉：https://github.com/DouyinFE/semi-design/blob/main/packages/semi-icons/src/styles/icons.scss#L3-L11
Contributor
There was a problem hiding this comment.
我看是能增强易读性，但是说在移动设备上有性能问题，先去掉吧https://developer.mozilla.org/zh-CN/docs/Web/CSS/text-rendering#%E5%80%BC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.