Skip to content

Fix StringValue.Create encode overload. #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastienros merged 3 commits into from
Feb 1, 2025
Merged

Fix StringValue.Create encode overload. #750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d532b6e
Fix `StringValue.Create` encode overload.
gumbarros Feb 1, 2025
468f3b0
Add tests
sebastienros Feb 1, 2025
2055114
Fix build
sebastienros Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Fluid.Tests/StringValueTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,17 @@ public void StringValueCreateNullShouldReturnEmpty()
// Assert
Assert.Equal(StringValue.Empty, stringValue);
}

[Theory]
[InlineData(true)]
[InlineData(false)]
public void StringValue_Create_InitializesProperties(bool encode)
{
var stringValue = StringValue.Create("a", encode);

// Assert
Assert.Equal("a", stringValue.ToStringValue());
Assert.Equal(encode, stringValue.Encode);
}
}
}
4 changes: 2 additions & 2 deletions Fluid/Values/StringValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public static StringValue Create(string s)
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static StringValue Create(string s, bool encode)
{
return Create(s, encode);
return new StringValue(s, encode);
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
Expand All @@ -93,7 +93,7 @@ public override bool Equals(FluidValue other)
return _value == other.ToStringValue();
}

// Delegating other types
// Delegating other types
if (other == BlankValue.Instance || other == NilValue.Instance || other == EmptyValue.Instance)
{
return other.Equals(this);
Expand Down