Reduce value type boxing in interop calls #787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* special case common bool and int property access * use abstract class instead of interface do reduce virtual dispatch cost
hishamco
requested changes
Apr 27, 2025
lahma
force-pushed
the
reduce-interop-boxing
branch
from
89a7e90 to
8175a98
Compare
lahma
force-pushed
the
reduce-interop-boxing
branch
from
8175a98 to
fe7c7ad
Compare
|
Did you check what I did in the other branch I mentioned last time? Similar to skip the boxing, but did it for any common type. Not the new specific classes though. |
No I didn't notice that one, it's quite big diff. Maybe you could bring improvements from there in smaller batches? |
|
No, it's a big breaking change, the goal is to ship a 3.0 with it. I'll move your improvements there though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When profiling NJsonSchema, found out that now after optimizations almost 10% of allocations originate from boolean value boxing (very common in code generation templates).