Ensure whitespace-only if branches still execute assign side effects#923
Merged
sebastienros merged 2 commits intomainfrom Feb 16, 2026
Merged
Conversation
Co-authored-by: sebastienros <1165805+sebastienros@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix bug preventing assignment execution due to IsWhitespaceOrCommentOnly
Ensure whitespace-only Feb 16, 2026
if branches still execute assign side effects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IfStatementcould short-circuitelsif/elsebranches markedIsWhitespaceOrCommentOnly, which skipped execution of non-output statements (notablyassign). This caused branch-local state (e.g.media_list_to_show) to remain unset even when the branch condition matched.Execution semantics in
IfStatementelsif/elsebranches whenIsWhitespaceOrCommentOnly == true.WriteToAsync, preserving existing whitespace suppression while executing side effects.Regression coverage
IfStatementTestsfor:assigninside a whitespace-onlyelsebranchassigninside a whitespace-onlyelsifbranchBehavioral impact
{% if false %} {% elsif true %} {% assign x = 'value' %} {% else %} {% assign x = 'other' %} {% endif %} {{ x }} {# now resolves to "value" instead of remaining undefined #}Original prompt
IsWhitespaceOrCommentOnlysometimes prevents the assignment from execution #921💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.