Fix Object.is when providing BigInt values

[tomatosalat0]

Object.is uses JsValue.SameValue() to compare two values. However, JsValue.SameValue() did not compare JsBigInt values.

The new test method ObjectIsReturnsTrueForSameBigInts fails without the change to JsValue.SameValue();

[tomatosalat0]

I don't know why the build did fail. The log shows that no tests failed, however the test process returned a non-zero exit code.

Is this a known issue?

The logs

Determining projects to restore...
  Restored /home/runner/work/jint/jint/Jint.Tests.PublicInterface/Jint.Tests.PublicInterface.csproj (in 3.75 sec).
  Restored /home/runner/work/jint/jint/Jint.Tests.Test262/Jint.Tests.Test262.csproj (in 3.75 sec).
  Restored /home/runner/work/jint/jint/Jint.Tests.CommonScripts/Jint.Tests.CommonScripts.csproj (in 3.74 sec).
  Restored /home/runner/work/jint/jint/Jint.Tests/Jint.Tests.csproj (in 3.75 sec).
  Restored /home/runner/work/jint/jint/Jint.Repl/Jint.Repl.csproj (in 2.54 sec).
  Restored /home/runner/work/jint/jint/Jint.AotExample/Jint.AotExample.csproj (in 2.54 sec).
  Restored /home/runner/work/jint/jint/Jint/Jint.csproj (in 3.93 sec).
  Restored /home/runner/work/jint/jint/Jint.Benchmark/Jint.Benchmark.csproj (in 5.73 sec).
  Jint -> /home/runner/work/jint/jint/artifacts/bin/Jint/release_netstandard2.1/Jint.dll
  Jint -> /home/runner/work/jint/jint/artifacts/bin/Jint/release_net462/Jint.dll
  Jint -> /home/runner/work/jint/jint/artifacts/bin/Jint/release_netstandard2.0/Jint.dll
  Jint -> /home/runner/work/jint/jint/artifacts/bin/Jint/release_net8.0/Jint.dll
  Tool 'test262harness.console' (version '1.0.1') was restored. Available commands: test262
  
  Restore was successful.
  You must install or update .NET to run this application.
  
  App: /home/runner/.nuget/packages/test262harness.console/1.0.1/tools/net8.0/any/Test262Harness.Console.dll
  Architecture: arm64
  Framework: 'Microsoft.NETCore.App', version '8.0.0' (arm64)
  .NET location: /usr/share/dotnet/
  
  The following frameworks were found:
    9.0.10 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]
    10.0.0-rc.2.25502.107 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]
  
  Learn more:
  https://aka.ms/dotnet/app-launch-failed
  
  To install missing framework, download:
  https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=8.0.0&arch=arm64&rid=linux-arm64&os=ubuntu.24.04
/home/runner/work/jint/jint/Jint.Tests.Test262/Jint.Tests.Test262.csproj(44,5): error MSB3073: The command "dotnet test262 generate" exited with code 150.
  Jint.Tests.CommonScripts -> /home/runner/work/jint/jint/artifacts/bin/Jint.Tests.CommonScripts/release_net9.0/Jint.Tests.CommonScripts.dll
Test run for /home/runner/work/jint/jint/artifacts/bin/Jint.Tests.CommonScripts/release_net9.0/Jint.Tests.CommonScripts.dll (.NETCoreApp,Version=v9.0)
VSTest version 17.14.1 (arm64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
  Jint.Tests.PublicInterface -> /home/runner/work/jint/jint/artifacts/bin/Jint.Tests.PublicInterface/release_net9.0/Jint.Tests.PublicInterface.dll
Test run for /home/runner/work/jint/jint/artifacts/bin/Jint.Tests.PublicInterface/release_net9.0/Jint.Tests.PublicInterface.dll (.NETCoreApp,Version=v9.0)
VSTest version 17.14.1 (arm64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
  Jint.Tests -> /home/runner/work/jint/jint/artifacts/bin/Jint.Tests/release_net9.0/Jint.Tests.dll
Test run for /home/runner/work/jint/jint/artifacts/bin/Jint.Tests/release_net9.0/Jint.Tests.dll (.NETCoreApp,Version=v9.0)
VSTest version 17.14.1 (arm64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.

Passed!  - Failed:     0, Passed:    68, Skipped:     0, Total:    68, Duration: 921 ms - Jint.Tests.PublicInterface.dll (net9.0)
[xUnit.net 00:00:03.53]     Jint.Tests.Runtime.ExtensionMethods.FlurlExtensionTest.CanUseFlurlExtensionMethods [SKIP]
  Skipped Jint.Tests.Runtime.ExtensionMethods.FlurlExtensionTest.CanUseFlurlExtensionMethods [1 ms]
[xUnit.net 00:00:03.78]     Jint.Tests.Runtime.Debugger.BreakPointTests.DebuggerStatementAndBreakpointTriggerSingleBreak [SKIP]
  Skipped Jint.Tests.Runtime.Debugger.BreakPointTests.DebuggerStatementAndBreakpointTriggerSingleBreak [1 ms]
[xUnit.net 00:00:04.23]     Jint.Tests.Runtime.GeneratorTests.Fibonacci [SKIP]
  Skipped Jint.Tests.Runtime.GeneratorTests.Fibonacci [1 ms]
[xUnit.net 00:00:04.25]     Jint.Tests.Runtime.GeneratorTests.Sending2 [SKIP]
  Skipped Jint.Tests.Runtime.GeneratorTests.Sending2 [1 ms]
[xUnit.net 00:00:04.25]     Jint.Tests.Runtime.GeneratorTests.Sending [SKIP]
  Skipped Jint.Tests.Runtime.GeneratorTests.Sending [1 ms]
[xUnit.net 00:00:05.77]     Jint.Tests.Runtime.InteropExplicitTypeTests.CallObjectMethodHiddenByInterface [SKIP]
  Skipped Jint.Tests.Runtime.InteropExplicitTypeTests.CallObjectMethodHiddenByInterface [1 ms]
[xUnit.net 00:00:05.99]     Jint.Tests.Runtime.GenericMethodTests.TestGenericClassDeriveFromGenericInterface [SKIP]
  Skipped Jint.Tests.Runtime.GenericMethodTests.TestGenericClassDeriveFromGenericInterface [1 ms]

Passed!  - Failed:     0, Passed:    28, Skipped:     0, Total:    28, Duration: 11 s - Jint.Tests.CommonScripts.dll (net9.0)
[xUnit.net 00:00:18.50]     Jint.Tests.Runtime.AsyncTests.ShouldHaveCorrectOrder [SKIP]
  Skipped Jint.Tests.Runtime.AsyncTests.ShouldHaveCorrectOrder [1 ms]

Passed!  - Failed:     0, Passed:  2533, Skipped:     8, Total:  2541, Duration: 15 s - Jint.Tests.dll (net9.0)
Error: Process completed with exit code 1.

[lahma]

If you rebase against latest main the tools should be able to run properly. NET 8 is no longer present in runner and test262 generator didn't have a roll-forward policy.

[tomatosalat0]

Looks like that fixed it - almost 😆. Looks like a flaky test now got in my way.

[lahma]

LGTM, thank you!