Contributor design docs - #109
Closed
dreab8 wants to merge 2 commits into
Closed
Conversation
sebersole
requested changes
May 25, 2026
sebersole
left a comment
sebersole
left a comment
Owner
There was a problem hiding this comment.
The changes use the phrases "discover" and "discovery" much too broadly imo. That makes me think "scanning". There is actually no discovery here, the AvailableResources are explicitly specified.
Owner
|
Locally for me this work has moved to the branch behind #108 which already has a lot of changes to this document. Even there I was still quite lax about the use of the term "discovery" so I went ahead and fixed it there. As we discussed, I also went ahead and pulled your changes into that form of the doc manually. Take a look at make sure you like it... https://github.com/sebersole/hibernate-models2/blob/orm-9-bootstrap/design/new-contributor-model-binding-guide.adoc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.