feat: add :Roslyn start command

[jmkelly]

I've had a few times where i wanted to stop and start the roslyn lsp and after doing a :Roslyn stop....there was no start. Maybe there is a good reason, but I was a bit confused so I've added it.

I took a look and saw that :Roslyn target does start, but it needed to select the sln file. I figure if there is only one sln file found, why ask? So I short cut it to start automatically if only one sln is found.

I'm using the conform plugin to force formatting.....but it appears it may be different from your defaults. If this is an issue, just let me know and I'll redo with your formatting.

Any comments, improvements, etc please let me know, as it my first lua PR. 🎉

[jmkelly]

one related question though, I figure there is a good reason, but any idea how we can hook into the native :LspStart, :LspStop and :LspRestart commands?

[seblyng]

Thanks! I will look at this later. I just didn't really have the need for Roslyn start when I initially implemented the commands, and I also think Roslyn restart might work as a start if I am not correct.

I would be open to adding a Roslyn start though.

one related question though, I figure there is a good reason, but any idea how we can hook into the native :LspStart, :LspStop and :LspRestart commands?

Yes. Previously it wasn't possible, because neovim didn't have a sense of a language server config. However, that is now fixed with vim.lsp.config which nvim-lspconfig have started to use.

There are two PR's that needs to be merged before they can be used:

• Feature: migrate builtin commands neovim/nvim-lspconfig#3734
• feat!: start using vim.lsp.config #178

After this, the only command really needed here is Roslyn target. However, I will not enforce a dependency on nvim-lspconfig here, so as long as the commands LspStart and etc is not upstreamed to neovim, I will keep the Roslyn commands here. If they however at one point do get upstreamed, I will probably deprecate the commands except for Roslyn target, but that doesn't seem to be in the very near future

[jmkelly]

I bailed on refactoring the target function and have just reverted it back to what it was before and only implemented the start functionality.

[seblyng]

Looks good to me👍 thanks!