-
Notifications
You must be signed in to change notification settings - Fork 46
feat(health): check for Razor extension presence #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add a health check to verify the presence of the Razor extension in the Mason roslyn package. Warn the user if the extension is not found, indicating that Razor support will be limited and suggesting installation via Mason.
seblyng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Rename minimal config file to `repro.lua` and update instructions to use `nvim -u repro.lua` for reproduction. Switch to using `lazy.minit` for plugin setup and add Mason registry details. Clarify steps for Roslyn language server installation and filetype setup.
Added health checks for the presence of vscode-html-language-server and html-lsp client configuration. Warns if either is missing, guiding users to improve Razor HTML support by installing or configuring the necessary components.
| }, | ||
| { | ||
| "seblyng/roslyn.nvim", | ||
| init = function() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I came to think about this as well. Isn't this also set by us in the plugin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to leave it in
A repro can be a good indication of explicit deps.
As a sidenote
I also don't love the adding of sources by the plugin if it does. Just from a supply chain/black magic reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It actually doesn't look like we do that anymore from a quick search on my phone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a sidenote
I also don't love the adding of sources by the plugin if it does. Just from a supply chain/black magic reason
Do you mean the adding of Mason registry automatically? In that case, yes, I removed it a while ago
Add a health check to verify the presence of the Razor extension in the Mason roslyn package. Warn the user if the extension is not found, indicating that Razor support will be limited and suggesting installation via Mason.