docs: add reason-aware repair policy matching RFC - #1
Draft
sebpalmerio wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a design RFC (
designs/reason-aware-repair-policy-matching.md) defining reason-aware repair policy matching and eligibility for Karpenter Node Repair.Problem
Node Repair currently maps a
NodeConditiontype and status to one toleration before replacing the Node. The reboot proposal adds another repair action, so diagnoses reported under the same condition may require different confidence delays, drain limits, and responses. Provider rules may also overlap and become eligible at different times. Matching must resolve those rules deterministically without relying on policy order or in-memory state.Proposal
Extend the provider-supplied
RepairPolicywithReasonRegexandAction, then:NodeCondition.reasonvalues with Go regular expressions.lastTransitionTimeand reconstruct it from current API state after restart.Related RFCs
How was this change tested?
N/A — documentation/design only.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
LLMs were used in the writing of this document, but the contribution is mine.