Fix current_runtime attribute on valve entities#395
Merged
Conversation
The `watering_in_progress_notification` WebSocket event delivers `run_time` at the top level with no `stations` array. The coordinator was storing `watering_status.stations` as an empty list, and the valve entity reads `stations[0].run_time` to populate `current_runtime`, leaving the attribute as null whenever watering started via a WebSocket event. Synthesize a stations entry from the event's `current_station` and `run_time` so the stored shape matches the API response. Fixes #394
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
watering_in_progress_notificationWebSocket event deliversrun_timeat the top level and does not include astationsarray. The coordinator was savingwatering_status.stationsas[], and the valve entity readsstations[0].run_timeto populatecurrent_runtime, so the attribute stayednullwhenever watering started via a WebSocket event.stationsentry from the event'scurrent_stationandrun_timeso the stored shape matches the API response andcurrent_runtimestays populated on valve entities.Fixes #394
Test plan
test_handle_watering_in_progress_synthesizes_stationsintests/test_coordinator.py./scripts/test— 142 passed./scripts/lint— all checks passed