Pick latest zone history irrigation by start_time#398
Merged
Conversation
The zone history sensor picked zone_irrigation[-1] from the first history item that had any entry for the zone. That relied on the upstream irrigation array being ordered by time, which isn't always true: when a later entry appears earlier in the array, the sensor surfaces the wrong run and its attributes (run_time, consumption, status). Select the entry with the greatest start_time across every history item instead. All statuses are considered so skipped runs still report consumption.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zone_irrigation[-1]from the first history item containing any entry for the zone. That relied on the upstreamirrigationarray being ordered by time, which isn't always true — a later entry appearing earlier in the array caused the sensor to surface the wrong run (wrongstart_time,run_time,status,consumption_gallons,consumption_litres).start_timeacross all history items. All statuses are considered so skipped runs still report their flow consumption.Test plan
pytest tests/test_sensor.py— all 11 tests pass, including a new case that asserts selection is by greateststart_timeregardless of array position or history-item position../scripts/lint— clean.