Switch to Opus audio codec. Support USB / ICS-43432 microphone(s) via auto-detection.#110
Draft
jkaczman wants to merge 1 commit into
Draft
Switch to Opus audio codec. Support USB / ICS-43432 microphone(s) via auto-detection.#110jkaczman wants to merge 1 commit into
jkaczman wants to merge 1 commit into
Conversation
… mic (auto detection)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, our microphone used a lot of CPU (~25%) with 3 piped processes and using the AAC codec. This has been significantly improved through a non-piped implementation using the Opus codec. Now we're at roughly 1-3% CPU for the microphone.
Additionally, beforehand we only supported ICS-43432 microphone. This has been changed to now auto-detect and support both a USB microphone or ICS-43432 microphone.
Notably, in addition to the significant CPU performance increase, Opus is required to support WebRTC livestreams (secluso/mobile_client#11). So this is stepping stone for that that is now complete.
Future work should fix livestream audio (as noted in #36). I did not attempt to solve that.
Pairs with secluso/os#31 for the OS compatibility side of things.