Replace OpenSSL-usage with pure-Rust implementations in camera_hub and server#73
Draft
Replace OpenSSL-usage with pure-Rust implementations in camera_hub and server#73
Conversation
jkaczman
changed the title
jkaczman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves away from OpenSSL in camera_hub and server into pure-Rust implementations.
Specifically, the changes are as follows:
[1] Vendored ort-sys and patched its binary download path so automatic ONNX Runtime downloads no longer pull in ureq's OpenSSL-backed native-tls stack. The downloader now uses ureq with rustls
[2] Replaced the server's UnifiedPush send path from web-push to web-push-native pinned to a specific Git commit (currently the latest) as the one published on crates.io is much older. The server now builds the encrypted Web Push request with web-push-native and sends it with reqwest. This removes the old web-push dependency and its OpenSSL-backed transport.
In the deploy tool, we still need to replace ssh2 with russh. However, this does not seem necessary as of today and will require a good chunk of work to complete.