fix and optimize openjpeg J2C encoder #4017
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of my previous PR about JPEG2000 encoding with OpenJPEG. #2054
There were a few issues with my previous attempt:
Here's what I did in this PR:
After a lot of testing I came very close to the results we get
with Kakadu. Here are some test files for comparison:
test_files.zip
The encoded files now respect the 1:8 ratio and have the correct number of discards.
With many thanks to @TommyTheTerrible for his help.