Introduce workflow dispatch, matrix strategy and mac functionality to qatest.yaml #4031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A workflow dispatch has been added in an attempt to not only manually trigger this workflow but to also test this from a different branch without having to first merge to develop. Also steps have been added to allow this workflow to run on mac runners when added. Mac runner info currently commented out.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
39
to
369
| echo "✅ ZIP file exists and is valid. Extracting..." | ||
| # Extract the ZIP | ||
| unzip -o "$INSTALLER_ZIP" -d "$EXTRACT_PATH" | ||
| # Find DMG file | ||
| INSTALLER_PATH=$(find "$EXTRACT_PATH" -name "*.dmg" -type f | head -1) | ||
| if [ -z "$INSTALLER_PATH" ]; then | ||
| echo "❌ Error: No installer DMG found in the extracted files!" | ||
| echo "📂 Extracted Files:" | ||
| ls -la "$EXTRACT_PATH" | ||
| exit 1 | ||
| fi | ||
| echo "✅ Installer found: $INSTALLER_PATH" | ||
| echo "INSTALLER_PATH=$INSTALLER_PATH" >> $GITHUB_ENV | ||
| - name: Install Second Life (Mac) | ||
| if: matrix.os == 'mac' | ||
| shell: bash | ||
| run: | | ||
| # Mac installation | ||
| echo "Mounting DMG installer..." | ||
| MOUNT_POINT="/tmp/secondlife-dmg" | ||
| mkdir -p "$MOUNT_POINT" | ||
| # Mount the DMG | ||
| hdiutil attach "${{ env.INSTALLER_PATH }}" -mountpoint "$MOUNT_POINT" -nobrowse | ||
| echo "✅ DMG mounted at $MOUNT_POINT" | ||
| # Find the app in the mounted DMG | ||
| APP_PATH=$(find "$MOUNT_POINT" -name "*.app" -type d | head -1) | ||
| if [ -z "$APP_PATH" ]; then | ||
| echo "❌ Error: No .app bundle found in the mounted DMG!" | ||
| exit 1 | ||
| fi | ||
| echo "Installing application to Applications folder..." | ||
| # Copy the app to the Applications folder (or specified install path) | ||
| cp -R "$APP_PATH" "${{ matrix.install-path }}" | ||
| # Verify the app was copied successfully | ||
| if [ ! -d "${{ matrix.install-path }}/$(basename "$APP_PATH")" ]; then | ||
| echo "❌ Error: Failed to install application to ${{ matrix.install-path }}!" | ||
| exit 1 | ||
| fi | ||
| echo "✅ Application installed successfully to ${{ matrix.install-path }}" | ||
| # Save mount point for cleanup | ||
| echo "MOUNT_POINT=$MOUNT_POINT" >> $GITHUB_ENV | ||
| - name: Wait for Installation to Complete (Mac) | ||
| if: matrix.os == 'mac' | ||
| shell: bash | ||
| run: | | ||
| echo "Waiting for installation to complete..." | ||
| # Sleep to allow installation to finish (adjust as needed) | ||
| sleep 30 | ||
| echo "✅ Installation completed" | ||
| - name: Cleanup After Installation (Mac) | ||
| if: matrix.os == 'mac' | ||
| shell: bash | ||
| run: | | ||
| # Mac cleanup | ||
| # Unmount the DMG | ||
| echo "Unmounting DMG..." | ||
| hdiutil detach "${{ env.MOUNT_POINT }}" -force | ||
| # Clean up temporary files | ||
| echo "Cleaning up temporary files..." | ||
| rm -rf "${{ env.DOWNLOAD_PATH }}" | ||
| rm -rf "${{ env.MOUNT_POINT }}" | ||
| echo "✅ Cleanup completed" | ||
| - name: Run QA Test Script (Mac) | ||
| if: matrix.os == 'mac' | ||
| shell: bash | ||
| run: | | ||
| Write-Host "Running QA Test script..." | ||
| python C:\viewer-sikulix-main\runTests.py | ||
| echo "Running QA Test script on Mac runner: ${{ matrix.runner }}..." | ||
| python "${{ matrix.install-path }}/runTests.py" | ||
| # - name: Upload Test Results | ||
| # uses: actions/upload-artifact@v3 | ||
| # if: always() | ||
| # uses: actions/upload-artifact@v4 | ||
| # with: | ||
| # name: test-results | ||
| # path: C:\viewer-sikulix-main\regressionTest\test_results.html | ||
| # name: test-results-${{ matrix.runner }} | ||
| # path: ${{ matrix.install-path }}/regressionTest/test_results.html |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 11 hours ago
To fix the issue, we will add a permissions block at the root level of the workflow to define the minimal permissions required. Based on the workflow's usage of the GITHUB_TOKEN (e.g., fetching artifacts), the contents: read permission is sufficient. This ensures that the token has only the necessary access to repository contents and no unnecessary write permissions.
Suggested changeset
1
.github/workflows/qatest.yaml
| @@ -2,2 +2,5 @@ | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| on: |
Copilot is powered by AI and may make mistakes. Always verify output.
There was a problem hiding this comment.
Didn't we already make this change?
marchcat
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A workflow dispatch has been added to not only manually trigger this workflow but to also hopefully be able to test this from a different branch without having to first merge to develop.
Added a matrix strategy to run the QA workflow on multiple runners simultaneously. In this case for runners: qa-windows-atlas and qa-dan-asus.
Also steps have been added to allow this workflow to run on mac runners when they're set up one day. Mac runner info currently commented out.