#5892 Inventory optimizations#5894
Open
akleshchev wants to merge 2 commits into
Open
Conversation
marchcat
approved these changes
Jun 3, 2026
marchcat
approved these changes
Jun 4, 2026
akleshchev
force-pushed
the
andreyk/viewer_5892
branch
from
2fadc14 to
7a843a7
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure certain high-priority AIS inventory updates (e.g., COF/outfit-related operations) are processed without being postponed by the existing throttling/yield behavior, while also adding a few small performance optimizations in inventory LLSD parsing/loading paths.
Changes:
- Introduces a “priority vs throttled” flag for AISUpdate processing and uses it to bypass timeout/yield logic for selected command types.
- Improves inventory cache load performance by reserving capacity for categories/items vectors and reducing LLSD lookup overhead in skeleton load.
- Refactors
LLInventoryItem::fromLLSD()to reduce string comparisons by switching on key length first.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| indra/newview/llinventorymodel.cpp | Minor perf improvements (avoid temp LLSD copies; reserve vectors before loading inventory cache). |
| indra/newview/llaisapi.h | Adds logging macro and introduces a new AISUpdate member flag controlling throttling behavior. |
| indra/newview/llaisapi.cpp | Implements the new “priority” throttling/timeout bypass behavior for selected AIS command types. |
| indra/llinventory/llinventory.cpp | Refactors LLSD item parsing to reduce per-field string comparisons (key-length prefilter). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
akleshchev
force-pushed
the
andreyk/viewer_5892
branch
from
7a843a7 to
91c9754
Compare
akleshchev
changed the title
akleshchev
force-pushed
the
andreyk/viewer_5892
branch
from
91c9754 to
ed24ef0
Compare
maxim-productengine
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure high priority messages aren't postponed.
Draft, as I'm not sure about correct ticket, nor whether this is final, I'm considering a 'general' priority mechanics that would be async inventory friendly.