Fix inaccurate "no copy" wording on restricted-permission scripts#5904
Open
jakethehoffer wants to merge 1 commit into
Open
Fix inaccurate "no copy" wording on restricted-permission scripts#5904jakethehoffer wants to merge 1 commit into
jakethehoffer wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3430.
The error shown when viewing a restricted-permission script said it was set to "no copy" or "no modify" even when the script is +copy, which is inaccurate. This updates the wording to "set with restricted permissions" (matching the phrasing Firestorm uses) and clarifies that copy and modify permissions are required, in both floater_live_lsleditor.xml (not_allowed) and panel_script_ed.xml (can_not_view).