-
Notifications
You must be signed in to change notification settings - Fork 46
Add feature for threshold ecdh psi #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @yunbo99, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the Threshold ECDH Private Set Intersection (PSI) feature, which enhances the standard ECDH PSI protocol by allowing participants to specify a maximum size for the resulting intersection. This ensures that the final intersection count does not exceed a predefined threshold, providing an additional layer of control over data exposure. The implementation includes new C++ components for both sender and receiver roles, along with updated configuration structures and examples, making it a robust extension to the existing PSI framework. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant new feature: Threshold ECDH PSI, which allows limiting the size of the intersection result. The implementation is well-structured, extending the existing ECDH PSI functionality through inheritance. The changes include new protocol logic, configuration options, comprehensive tests, benchmarks, and documentation. The overall approach is solid. I've identified a few areas for improvement, such as correcting some copy-paste errors in logging, removing unused code, improving code clarity, and fixing typos in comments. These suggestions should help enhance the quality and maintainability of the new feature.
No description provided.