Standardize social media fields to accept both URLs and URIs. - #374
Open
TalysonSoares wants to merge 1 commit into
Open
TalysonSoares wants to merge 1 commit into
TalysonSoares wants to merge 1 commit into
Conversation
TalysonSoares
marked this pull request as draft
July 29, 2024 13:20
saracamilo
previously approved these changes
Jul 29, 2024
TalysonSoares
force-pushed
the
improvement/social-media-links
branch
3 times, most recently
from
July 29, 2024 19:06
bafef54 to
aa13ef5
Compare
TalysonSoares
marked this pull request as ready for review
July 29, 2024 19:45
TalysonSoares
force-pushed
the
improvement/social-media-links
branch
3 times, most recently
from
July 30, 2024 14:25
ec1618e to
6869b98
Compare
henriquelopeslima
approved these changes
Jul 30, 2024
TalysonSoares
force-pushed
the
improvement/social-media-links
branch
from
August 1, 2024 22:33
6869b98 to
7bdb8cb
Compare
TalysonSoares
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neste PR, criei um enum de redes sociais que contém as expressões regulares necessárias para a validação de URLs e usuários das redes sociais, veja as alterações em SocialMediaEnum.php.
Refatorei o método parseSocialMediaUser, utilizando Object Calisthenics e boas práticas, e incrementei o método para aceitar diferentes tipos de URLs do Spotify, tanto de artistas quanto de usuários comuns. Além disso, alterei a função buildSocialMediaLink para que ela construa URLs corretamente para outras redes sociais, como Spotify e LinkedIn, veja as alterações em Utils.php e Utils.js.
Removi o ícone do Twitter e adicionei o novo ícone do X, além de criar um novo campo para incluir o TikTok.
Atualizei o ícone do X no componente entity-header, mas notei que os links nesse mesmo componente estão com o href apontando para a URL errada. Este problema será corrigido em um novo PR.