Annotate hash module #970
Open
Annotate hash module #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is not just about hash module, right? Also, what's missing for marking this ready for review? |
yeah there's refactor (and tightening) of mypy config and minor annotation fixes that result from that
possibly just fixing the PR message? |
jku
commented
Mar 18, 2025
* Move config to pyproject.toml * Turn on useful mypy options * Don't check tests with mypy: too much to fix right now * Add py.typed to announce this project is type annotated * Fix various annotation issues Issues remain in hash module Signed-off-by: Jussi Kukkonen <[email protected]>
It's not really possible to annotate hash correctly but let's do something... Signed-off-by: Jussi Kukkonen <[email protected]>
This is useful since it will notice use of too new futures (or lack of "from __future__ import annotations"). Signed-off-by: Jussi Kukkonen <[email protected]>
|
Only change in this force-push is that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to statically analyze calls to securesystemslib in other projects
Changelog:
hashlib.blake2b()instead of hashlib.new() for the 256bit blake2bFileSystemBackend.__new__(): theoretically an API change but I don't thinkobject.__new__()takes extra args so I doubt it was ever used.