Skip to content

docs: Add VPN section to FAQ #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: live
Choose a base branch
from

Conversation

Oakleafknight06
Copy link

Added a vpn section to the FAQ, noting specifics about proton and mullvad. First sentence likely needs more details.

@Oakleafknight06
Copy link
Author

@RoyalOughtness
Copy link
Contributor

It says I need commit signature verification. Should I set that up as per https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification#ssh-commit-signature-verification

yes please

Copy link
Contributor

@RoyalOughtness RoyalOughtness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@Oakleafknight06
Copy link
Author

It says I need commit signature verification. Should I set that up as per https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification#ssh-commit-signature-verification

yes please

Set this up. How does this affect the unsigned commit already committed? Do I need to do anything to fix that?

@RoyalOughtness
Copy link
Contributor

It says I need commit signature verification. Should I set that up as per https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification#ssh-commit-signature-verification

yes please

Set this up. How does this affect the unsigned commit already committed? Do I need to do anything to fix that?

you can either squash into a new signed commit, or i can temporarily bypass for this pr :)

@Oakleafknight06
Copy link
Author

It says I need commit signature verification. Should I set that up as per https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification#ssh-commit-signature-verification

yes please

Set this up. How does this affect the unsigned commit already committed? Do I need to do anything to fix that?

you can either squash into a new signed commit, or i can temporarily bypass for this pr :)

Attempted to squash, but it didn't seem to work.
(This is what I ran:)

> git commit -a -S -m "typo fix"
> git rebase -i HEAD~2
> git rebase --continue
> git push

Admittedly I am not very familiar with git, the most I have used it is for my bluebuild custom image. Can you either tell me how I should be doing this, or make the exception for the first commit like you said?

@Oakleafknight06
Copy link
Author

If I have made the requested change, should I click the "resolve conversation" button where you requested said changes?

@Oakleafknight06
Copy link
Author

I believe this should be good to go, however, I have issues with trying to run and test Jekyll locally (and don't have the time to fix that right now) so I have not tested that the images show up on the website correctly (as I am not sure how the image rendering / sizing works without that.)

@EsseLowNitro
Copy link
Collaborator

image

This is a problem I let slide and likely should be fixed categorically with CSS.

@Oakleafknight06
Copy link
Author

Makes sense. Should the CSS fix be in this pull request, or somewhere separate?
Also, how did you access the preview site? I’m unaware of how that works

@EsseLowNitro
Copy link
Collaborator

I made a separate pull request for this image fix (#99).

Cloudflare deploys previews (branch-name.secureblue.pages.dev) for repo branches other than live, which goes into production (secureblue.dev), and creating branches directly on the repo is something @RoyalOughtness and I have access to. I made a temporary branch copying the changes of your PR to test it.

This can be improved in the future if a good local testing workflow is figured out, which could then be documented in this project's readme. But at least, with #99 getting merged, all images are guaranteed to render properly from then on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants