Trillian extend - createTree and updateTree #39
Conversation
|
|
||
| Describe("Set tree state to DRAINING", func() { | ||
| It("should update tree state", func() { | ||
| cmd := fmt.Sprintf("oc run --image registry.redhat.io/rhtas/updatetree-rhel9@sha256:1a95a2061b9bc0613087903425d84024ce10e00bc6110303a75637fb15d95d34 --restart=Never --attach=true --rm=true -q -- updatetree --admin_server=trillian-logserver:8091 --tree_id=%s --tree_state=DRAINING", currentTreeID) |
There was a problem hiding this comment.
First, avoid hard coding any version of the tested artifact binary/image in the test suite. Hard coding versions undermines the verification process.
Next, please use the same method as is used for other CLI tools to download the updatetree and createtree binaries. This ensures consistency and reliability across the codebase, and it is essential for all tests in this repository to work seamlessly on both OCP (OpenShift Container Platform) and RHEL (Red Hat Enterprise Linux) environments. The current implementation does not meet this requirement.
| }) | ||
| }) | ||
|
|
||
| Describe("Set tree state to DRAINING", func() { |
There was a problem hiding this comment.
Additionally, please do not manipulate the existing tree because it will cause problems for other tests running against this service. Instead, create a new tree that is independent and work with it. The current implementation of tests causes side effects that lead to instability in all tests.
No description provided.