[Research] [Do not merge] Claude generated comparison between protobuf, cap'n proto and flatbuffers#708
Draft
darioalessandro wants to merge 1 commit into
Draft
[Research] [Do not merge] Claude generated comparison between protobuf, cap'n proto and flatbuffers#708darioalessandro wants to merge 1 commit into
darioalessandro wants to merge 1 commit into
Conversation
👋 Thanks for your contribution!A maintainer will review your changes shortly. ✅ Automated ChecksCI/CD tests will run automatically. Please ensure all checks pass before requesting review. 🚀 Preview DeploymentsMaintainers can test this PR in a live environment using these commands:
Preview URLs will be posted automatically once deployed. |
darioalessandro
changed the title
testradav
pushed a commit
to testradav/videocall-rs
that referenced
this pull request
May 18, 2026
…E breakage Resolves security-union#714. Under the priority-drop policy introduced in security-union#708, AES_KEY was classified as `Control`, so it was never preemptively dropped but COULD still be dropped silently at the channel level if the relay's outbound channel hit true overflow (100% full). AES_KEY is the symmetric half of the E2EE handshake (paired with RSA_PUB_KEY, which is already Critical) — losing it breaks encrypted communication for the affected peer pair with no `overflow_critical` label and no page-able alert. Both halves of the handshake must be treated symmetrically. Changes: - `OutboundPriority::classify` now classifies `PacketType::AES_KEY` as `Critical` (alongside `SESSION_ASSIGNED`, `CONGESTION`, `RSA_PUB_KEY`, `MEETING`). - Module docstring and enum doc-comments updated to list AES_KEY in the Critical set, with a brief explanation of the E2EE-handshake rationale. - Existing `classify_aes_key_is_control` test flipped to `classify_aes_key_is_critical`. - `spec_critical_set_is_session_congestion_rsa_meeting` renamed to `spec_critical_set_is_session_congestion_rsa_aes_meeting` and extended to assert AES_KEY membership. - `realchannel_critical_admit_even_at_99_percent_fill` extended to cover AES_KEY. - New `aes_key_is_critical_and_never_dropped` test sweeps fill levels (0/50/80/90/95/99%) to lock in the never-preempt invariant. Quality gates: - `cargo fmt -p videocall-api` clean. - `cargo clippy -p videocall-api --all-targets -- -D warnings` clean. - `cargo test -p videocall-api --lib actors::priority_drop` — 37/37 passing (36 previous tests + 1 new). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
testradav
pushed a commit
to testradav/videocall-rs
that referenced
this pull request
May 18, 2026
…iority-drop-by-media-type feat(relay): priority-aware drop policy on per-session outbound channel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Testing
Other