fix(ButtonV2): button corner when used as Link. PLAT-1438#1363
Merged
Douglasgomes027 merged 1 commit intomainfrom Feb 20, 2026
Conversation
longueiraemiliano
approved these changes
Jan 27, 2026
d1f1dd9 to
85e9ff0
Compare
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
384c1a1 to
b2ee30a
Compare
b2ee30a to
48e32ee
Compare
🚀 Snapshot Build PublishedA snapshot version has been published to GitHub Packages for testing: Snapshot Version: You can install this version in your project using (with yarn add @securityscorecard/design-system@pr-1363Published to GitHub Packages; snapshot versions are not unpublished when the PR is closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an inconsistency where ButtonV2 loses its expected corner radius when rendered as a Link component via
as={Link}, making it look different from the regular button and fromas="a"usage.When
ButtonV2is used as a navigation button (e.g.,as={Link}), the rendered element can inherit/override styles from the Link component and end up with an incorrectborder-radius(e.g., appearing as 4px instead of the design system’s button radius). This causes visual inconsistency across the UI and in Storybook.Solution
border-radius: var(--sscds-radii-button) !important;AsLinkComponentto document and compare:ButtonV2 as={Link}ButtonV2 as="a"LinkButtonV2This is a design-system correctness fix: regardless of which underlying element
ButtonV2renders (button,a, orLink), it should keep the same core button styling, including corner radius.