Skip to content

Conversation

@lwjohnst86
Copy link
Member

Description

Closes #181

This PR needs an in-depth review.

Checklist

  • Formatted Markdown
  • Ran just run-all

@lwjohnst86 lwjohnst86 requested a review from a team as a code owner December 8, 2025 12:46
@lwjohnst86 lwjohnst86 moved this from Todo to Approved in Iteration planning Dec 8, 2025
@lwjohnst86 lwjohnst86 moved this from Approved to In Review in Iteration planning Dec 8, 2025
Copy link
Member

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Some minor suggestions:

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Iteration planning Dec 8, 2025
@lwjohnst86 lwjohnst86 requested a review from signekb December 8, 2025 15:42
@lwjohnst86 lwjohnst86 moved this from In Progress to In Review in Iteration planning Dec 8, 2025
joelostblom
joelostblom previously approved these changes Dec 8, 2025
Copy link

@joelostblom joelostblom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Only minor comments; fixes optional.

Copy link
Member

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just one last thing, format, and then it's 👌


# Normally you'd read in the `datapackage.json` file, but we'll
# show the actual contents here as a Python dict.
# show the actual contents here as a Python dict. Can use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# show the actual contents here as a Python dict. Can use
# show the actual contents here as a Python dict. You can use

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Iteration planning Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

Post about check-datapackage

4 participants