-
Notifications
You must be signed in to change notification settings - Fork 0
feat: ✨ post on publishing check-datapackage
#184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
signekb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Some minor suggestions:
Co-authored-by: Signe Kirk Brødbæk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Only minor comments; fixes optional.
Co-authored-by: Joel Ostblom <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just one last thing, format, and then it's 👌
|
|
||
| # Normally you'd read in the `datapackage.json` file, but we'll | ||
| # show the actual contents here as a Python dict. | ||
| # show the actual contents here as a Python dict. Can use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # show the actual contents here as a Python dict. Can use | |
| # show the actual contents here as a Python dict. You can use |
Description
Closes #181
This PR needs an in-depth review.
Checklist
just run-all