Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable nonTransitiveRClass and fix breakage it causes #884

Merged
merged 2 commits into from
Mar 12, 2025
Merged

Enable nonTransitiveRClass and fix breakage it causes #884

merged 2 commits into from
Mar 12, 2025

Conversation

grote
Copy link
Collaborator

@grote grote commented Mar 7, 2025

No description provided.

@grote grote requested review from chirayudesai and mikeNG March 7, 2025 13:31
@grote
Copy link
Collaborator Author

grote commented Mar 7, 2025

i did a quick test by throwing a fake exception to cause the error and the color looked OK in light and dark theme.

cdesnoai
cdesnoai suggested changes Mar 11, 2025
View reviewed changes
Copy link

@cdesnoai cdesnoai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails to build in AOSP,

packages/apps/Seedvault/storage/lib/src/main/java/org/calyxos/backup/storage/ui/restore/SnapshotFragment.kt:61:75: error: unresolved reference: attr
                    val color = MaterialColors.getColor(emptyStateView, R.attr.colorError)

@grote
Copy link
Collaborator Author

grote commented Mar 12, 2025

thanks for testing, but also strange. it builds fine on QPR1, why would it not find R.attr which is a normal thing since forever.

@chirayudesai
Copy link
Member

seedvault/app/src/main/java/com/stevesoltys/seedvault/restore/RestoreSetAdapter.kt

Line 87 in aa4468b

MaterialColors.getColor(apkView, R.attr.colorError)

@chirayudesai
Copy link
Member

TODO: Enable https://github.com/seedvault-app/seedvault/blob/android15/gradle.properties#L12

@grote grote force-pushed the fix-private-colorResource branch from 12f0b37 to 35bbb7b Compare March 12, 2025 13:20
@grote grote changed the title Properly resolve color attribute Enable nonTransitiveRClass and fix breakage it causes Mar 12, 2025
@grote
Copy link
Collaborator Author

grote commented Mar 12, 2025

should build in AOSP now, just tested it

@grote grote force-pushed the fix-private-colorResource branch from 35bbb7b to 8c24628 Compare March 12, 2025 13:27
@chirayudesai
Copy link
Member

should build in AOSP now, just tested it

It does, thanks!

@chirayudesai chirayudesai merged commit 60a63d3 into seedvault-app:android15 Mar 12, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdesnoai cdesnoai cdesnoai requested changes

@chirayudesai chirayudesai chirayudesai approved these changes

@mikeNG mikeNG Awaiting requested review from mikeNG

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grote @chirayudesai @cdesnoai