Try to follow M3 guidelines for text#927
Try to follow M3 guidelines for text#927lucasmz-dev wants to merge 1 commit intoseedvault-app:android16from
Conversation
lucasmz-dev
force-pushed
the
strings-rework
branch
from
3345adc to
aa9844b
Compare
app/src/main/res/values/strings.xml
Outdated
| <string name="settings_backup_scheduling_title">Backup scheduling</string> | ||
| <string name="settings_backup_app_check_title">Check integrity</string> | ||
| <string name="settings_backup_app_check_summary">Ensure that backup is working for restore</string> | ||
| <string name="settings_backup_app_check_summary">Ensure that backup\'s working for restore</string> |
There was a problem hiding this comment.
TODO: the backup
There was a problem hiding this comment.
is there an official recommendation to use backup's working instead of backup is working? Is this even proper English?
There was a problem hiding this comment.
With native en_US hat on, it should remain "backup is working". The use of ' can be confusing, being both for possessive, and for contractions. A contraction example is "isn't". A confusing example is "it's" for "it is", and "its" for the possessive My perception is that as general rule, contractions should be avoided in formal writing, but opinions differ. Personally, I think it is better to avoid contractions in text that will be read by non-native speakers on the grounds that they are not helpful and increase the required reading skill level. We don't really have a "strings should be in simplified English when possible" norm, but I think a bias in that direction is good, as most people are not native Engilsh speakers but feel they have to learn some to cope with computers, as English is now the lingua franca.
I don't believe it is proper to form contractions "foo's" from random "foo is". I found a page with 80 standard contractions. Surprising to me, it says that random nouns and is can become a contraction. However, I stand by the idea that it is unhelpful to the reader and too informal.
Stepping back, I don't find "backup is working for restore" to be clear.
There was a problem hiding this comment.
I think I overdone contractions. I'm not a native English speaker (is anyone here?) and I didn't really learn all the formality and stuff, literally everything was from informal conversation.
grote isn't either AFAIK, not sure about Steve. So it could end up being literally a bunch of non natives trying to figure out what to do. Quite common in FOSS tbh 😅
I think I'll go ahead and fix contractions to not be used for nouns.
For reference, this was from https://m3.material.io/foundations/content-design/style-guide/grammar-and-punctuation
There was a problem hiding this comment.
I did not know about the M3 style guide. Given that, I really can't object to the normal contractions, the top 10 or so that aren't very frequent. I am still concerned that non-native speakers trying to read English will have a harder time.
The style guide does not suggest noun's for "noun is", by my reading. Plus, I find it very confusing, as a native speaker, and think it would be even harder to parse for a non-native speaker.
There was a problem hiding this comment.
There's also that en_GB rules are slightly different. I don't know if Android writes in en_US and en_GB, en_AU, en_NZ, en_CA get lightly translated. My friends Bruce and Sheila would want an AU-specific translation.
There was a problem hiding this comment.
There are variants of English in Weblate, but they're not well maintained; Australia and United Kingdom are the ones that even have translations. I had to manually fix them a while ago for source-string changes otherwise they'd still be using older variants, they were literally the same so...
I don't know if anything even changes between them, honestly
app/src/main/res/values/strings.xml
Outdated
| <string name="settings_backup_file_check_title">Check backup integrity</string> | ||
| <string name="settings_backup_file_check_summary">Make sure my backup is working for restoring files</string> | ||
| <string name="settings_backup_file_check_title">Check integrity</string> | ||
| <string name="settings_backup_file_check_summary">Ensure that file backup\'s working for restore</string> |
There was a problem hiding this comment.
the backup, again
|
|
||
| <string name="backup_section_system">System data</string> | ||
| <string name="backup_sms">SMS text messages</string> | ||
| <string name="backup_sms">SMS messages</string> |
There was a problem hiding this comment.
This is probably good, as so many people use "text" with varying meanings.
| <string name="backup_app_stopped_no_intent">Cannot launch app</string> | ||
| <!-- This text gets shown for apps that the OS did not try to backup for whatever reason e.g. no backup was run yet --> | ||
| <string name="backup_app_not_yet_backed_up">Waiting to back up…</string> | ||
| <string name="backup_app_not_yet_backed_up">Awaiting backup…</string> |
app/src/main/res/values/strings.xml
Outdated
| <string name="backup_app_was_stopped">Not backed up as it wasn\'t used recently</string> | ||
| <string name="restore_app_was_stopped">Was not backed up as it hadn\'t been used recently</string> | ||
| <string name="backup_app_was_stopped">Not backed up as it is force-stopped</string> | ||
| <string name="restore_app_was_stopped">Was not backed up as it was force-stopped</string> |
There was a problem hiding this comment.
It is not clear that this change is correct. Say what is really happening. Perhaps "Not backed up because app is not running."
There was a problem hiding this comment.
Isn't the definition of running in Android kind of all over the place? It's not really clear to the user what each thing means, it may not be actively running or not, and it can still be backed up, no?
I feel like oversimplifying might be hurtful here
There was a problem hiding this comment.
- I thought that the OS could stop an app (that was in background not doing anything) if the OS believes it isn't being used. I have the further impression this is no different from force stopped, from seedvault point of view. (PS there I could using contractions, but I'm just commenting, not writing docs, and "isn't' is one of the most common usages.
- In general I believe that the Android app practice that there is not documentation is regrettable. This discussion points out that a longer explanation is needed in the manual, and maybe it's there, which raises the question of how to point to it.
| <string name="notification_finalizing_text">Finalizing backup…</string> | ||
| <string name="notification_apk_text">Backing up APK of %s</string> | ||
| <string name="notification_apk_not_backed_up">Saving list of apps we can not back up.</string> | ||
| <string name="notification_apk_not_backed_up">Saving a list of apps that can\'t be backed up</string> |
There was a problem hiding this comment.
This line is a bit confusing to me overall. What does this even mean?
From the string name, I would guess it would mean like 'oh like system apps that don't need to have APKs backed up' but then from the text it then sounds like APKs that break things, aren't allowed to be backed up
If you think from the name, it could also sound like it is saying "We can >NOT BACK UP<" as in you don't need to back up
|
|
||
| <string name="notification_restore_error_channel_title">Auto restore flash drive error</string> | ||
| <string name="notification_restore_error_title">Could not restore data for %1$s</string> | ||
| <string name="notification_restore_error_title">Couldn\'t restore data for %1$s</string> |
There was a problem hiding this comment.
In general, I am opposed to all changes toward contractions.
There was a problem hiding this comment.
I don't really agree for this case, but what about "It wasn't possible to" ?
app/src/main/res/values/strings.xml
Outdated
|
|
||
| <string name="storage_internal_warning_title">Warning</string> | ||
| <string name="storage_internal_warning_message">You have chosen internal storage for your backup. This will not be available when your phone is lost or broken.</string> | ||
| <string name="storage_internal_warning_message">You\'ve chosen internal storage for your backup. This won\'t be available when your phone\'s lost or broken.</string> |
There was a problem hiding this comment.
phone no longer has a contraction
app/src/main/res/values/strings.xml
Outdated
| <string name="settings_backup_recovery_code_summary">Verify the existing code or generate a new one</string> | ||
| <string name="settings_backup_storage_dialog_title">Beta feature</string> | ||
| <string name="settings_backup_storage_dialog_message">Backing up files is beta and might not work. Do not rely on it for important data.</string> | ||
| <string name="settings_backup_storage_dialog_message">File backup\'s still in beta and might not work. Don\'t rely on it for important data.</string> |
There was a problem hiding this comment.
"Support for backing up files is a beta feature. Don't rely on this for important data."
Perhaps?
| <string name="storage_fake_nextcloud_summary">Tap to install</string> | ||
| <string name="storage_fake_nextcloud_summary_installed">Tap to set up account</string> | ||
| <string name="storage_fake_nextcloud_summary_unavailable">Account not available. Set one up (or disable passcode).</string> | ||
| <string name="storage_fake_nextcloud_summary_unavailable">Account not available. Set one up, or disable the app\'s passcode.</string> |
There was a problem hiding this comment.
Or disable your passcode in Nextcloud? Not sure the context here
There was a problem hiding this comment.
Yeah need to check
Isn't Nextcloud backup, like... disabled anyway right now though? Is this string even possible to reach
app/src/main/res/values/strings.xml
Outdated
| <string name="recovery_code_error_checksum_word">Your code\'s invalid. Please check all words as well as their position and try again!</string> | ||
| <string name="recovery_code_verification_ok_title">Recovery code verified</string> | ||
| <string name="recovery_code_verification_ok_message">Your code is correct and will work for restoring your backup.</string> | ||
| <string name="recovery_code_verification_ok_message">Your code\'s correct and will work when you need to restore.</string> |
There was a problem hiding this comment.
Anywhere that we're just replacing is with apostrophe s feels off to me (personally).
lucasmz-dev
changed the title
lucasmz-dev
changed the title
lucasmz-dev
force-pushed
the
strings-rework
branch
from
5598cc5 to
436ac03
Compare
lucasmz-dev
force-pushed
the
strings-rework
branch
from
56903ad to
398c1bc
Compare
4 participants
Not really planning this in a formal way just kind of looking through it and being like 'I don't like that, let me change it'
In this I did notice that some strings mention 'Automatic restore' as the only solution or "What you need to do" but now we have the regular restore so...
I wanna read some more about Google's M3 rules for text as well but I haven't yet
Consider this a 'draft' but also not if you find this a good thing?