* adding yield at end of run block, to allow sensu-server shutdown#14
Open
sethcall wants to merge 3 commits intoseegno:masterfrom
Open
* adding yield at end of run block, to allow sensu-server shutdown#14sethcall wants to merge 3 commits intoseegno:masterfrom
sethcall wants to merge 3 commits intoseegno:masterfrom
Conversation
Author
|
Also fixing issue where time posted to influx was in milliseconds, not microseconds. |
…s the values correctly
|
Hello @sethcall Can you separate this into 2 pull requests? Also is yield still necessary ? |
|
Thanks for this extension! Just wanted to say that I had to add the yield when using sensu 0.19.2 before the server would restart properly. |
|
👍 |
|
@sethcall can you rebase with master? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without adding this yield, I could never shutdown sensu-server using
/etc/init.d/sensu-server restartIn the logs, you'd see this, where handlers_in_progress_count would be a higher value, depending on how many influxdb handler calls were made.
This patch allows me to restart OK.