feat: Add a new ec2 restart option that can also change the instance type#487
feat: Add a new ec2 restart option that can also change the instance type#487RyanSattlerWork merged 8 commits intomasterfrom
Conversation
src/aec/main.py
Outdated
| Cmd(ec2.restart, [ | ||
| config_arg, | ||
| Arg("ident", type=str, help="Name tag of instance or instance id"), | ||
| Arg("-t", "--type", type=str, help="New type for the instance") |
There was a problem hiding this comment.
not sure if I should use this type of arg here but since the param is optional it felt correct?
There was a problem hiding this comment.
yeh makes sense, what about using-m for modify here tho? to align with ec2 modify
There was a problem hiding this comment.
t feels a little more intuitive here to me but this might be more consistent... I'll change it
There was a problem hiding this comment.
ok let's keep it as -t then
src/aec/main.py
Outdated
| Cmd(ec2.restart, [ | ||
| config_arg, | ||
| Arg("ident", type=str, help="Name tag of instance or instance id"), | ||
| Arg("-t", "--type", type=str, help="New type for the instance") |
There was a problem hiding this comment.
yeh makes sense, what about using-m for modify here tho? to align with ec2 modify
tekumara
left a comment
tekumara
left a comment
There was a problem hiding this comment.
Very handy, thank you!
| return describe(config, ident) | ||
|
|
||
|
|
||
| def restart(config: Config, ident: str, type: str | None = None, wait_ssm: bool = False) -> list[Instance]: |
There was a problem hiding this comment.
would you mind adding this to docs/ec2.md and then run make docs to update the usage
2 participants
I've also installed and tested this locally and it seems to work.