RFC: Run skuba upgrades in test CI environments #2173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 69f2ea6 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Why do we
would swapping the order be bad? |
samchungy
commented
Dec 10, 2025
Contributor
Author
I will defer that to @72636c |
zbrydon
approved these changes
Dec 19, 2025
Contributor
zbrydon
left a comment
zbrydon
left a comment
There was a problem hiding this comment.
Happy with this before/if we investigate/commit to a potentially parallel lint and test command that reports errors in both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our templates currently advocate for running tests before lint.
This is problematic if we want to introduce runtime changes to the
testinterface as when theteststep fails thelintstep won't be run. This will be especially problematic when we switchJestout forvitestbecause everything will break.I propose running skuba upgrades in CI when running
skuba test