Add codespell support (config, workflow to detect/not fix) and make it fix few typos#35
Open
yarikoptic wants to merge 5 commits into
Open
Add codespell support (config, workflow to detect/not fix) and make it fix few typos#35yarikoptic wants to merge 5 commits into
yarikoptic wants to merge 5 commits into
Conversation
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
j-wags
reviewed
Jul 24, 2024
| try: | ||
| triangulation = Delaunay(points) | ||
| vor = Voronoi(points) | ||
| voronoi = Voronoi(points) |
Collaborator
There was a problem hiding this comment.
While this appears to be unused, it's a little weird that the tool suggests changes to variable names.
Author
There was a problem hiding this comment.
It was me reacting on tool finding vor to be a close hit to a typo. I did that in a separate commit. If you would like I can just remove variable altogether or a full line - wasn't sure if code doesn't rely on some side effects there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More about codespell: https://github.com/codespell-project/codespell .
I personally introduced it to dozens if not hundreds of projects already and so far only positive feedback.
CI workflow has 'permissions' set only to 'read' so also should be safe.