Skip to content

Conversation

@ventiph
Copy link

@ventiph ventiph commented Oct 31, 2025

Description

Moved event description from author field to title field in Discord embed notification. This fixes the issue of the Discord notification popup not displaying the actual thing that triggered the notification, as outlined in #2117.

Screenshots

New notification:
image

To-Dos

  • Disclosed any use of AI (see our policy)

The code change was primarily authored by GPT-5 mini through Github, though I verified the change myself

  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

Fixes #2117

@ventiph ventiph marked this pull request as ready for review October 31, 2025 19:08
@ventiph ventiph requested a review from a team as a code owner October 31, 2025 19:08
@0xSysR3ll 0xSysR3ll changed the title feat(notifications): Add event to Discord notification embed title refactor(notifications): move event from author to title field in Discord Embed Oct 31, 2025
@0xSysR3ll
Copy link
Contributor

Can you please edit your PR description to match the template we gave ? 😄

@ventiph
Copy link
Author

ventiph commented Nov 2, 2025

@0xSysR3ll Updated to match the template, let me know if I missed anything

@0xSysR3ll
Copy link
Contributor

@0xSysR3ll Updated to match the template, let me know if I missed anything

Thanks. Even though it is a small change, you still need to describe what you did and why.
1-2 phrases are enough.

@ventiph
Copy link
Author

ventiph commented Nov 2, 2025

@0xSysR3ll Updated to match the template, let me know if I missed anything

Thanks. Even though it is a small change, you still need to describe what you did and why. 1-2 phrases are enough.

Done

@0xSysR3ll
Copy link
Contributor

LGTM now ! As it is a small change and kind of a fix, I think we could merge this. Wdyat ?

@ventiph
Copy link
Author

ventiph commented Nov 4, 2025

Is there anything else I need to do to get this merged?

@0xSysR3ll
Copy link
Contributor

Is there anything else I need to do to get this merged?

Nope, just wait for another review :)

@ventiph
Copy link
Author

ventiph commented Nov 20, 2025

Is there anyone I can tag to get another review? It will only take a moment to review.

@0xSysR3ll
Copy link
Contributor

Is there anyone I can tag to get another review? It will only take a moment to review.

As soon as the first release is out we'll have more time to review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Richer Discord Notifications

3 participants