-
-
Notifications
You must be signed in to change notification settings - Fork 489
refactor(notifications): move event from author to title field in Discord Embed #2119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Can you please edit your PR description to match the template we gave ? 😄 |
|
@0xSysR3ll Updated to match the template, let me know if I missed anything |
Thanks. Even though it is a small change, you still need to describe what you did and why. |
Done |
|
LGTM now ! As it is a small change and kind of a fix, I think we could merge this. Wdyat ? |
|
Is there anything else I need to do to get this merged? |
Nope, just wait for another review :) |
|
Is there anyone I can tag to get another review? It will only take a moment to review. |
As soon as the first release is out we'll have more time to review and merge. |
Description
Moved event description from author field to title field in Discord embed notification. This fixes the issue of the Discord notification popup not displaying the actual thing that triggered the notification, as outlined in #2117.
Screenshots
New notification:

To-Dos
The code change was primarily authored by GPT-5 mini through Github, though I verified the change myself
Issues Fixed or Closed
Fixes #2117