feat(requests): mark requests as failed when Radarr/Sonarr unreachable #2171
+50
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes requests silently failing when Radarr/Sonarr are unreachable. Requests are now marked as `FAILED` and notifications are sent to alert both users and admins. Signed-off-by: 0xsysr3ll <[email protected]>
Member
|
I wouldn't call this a fix, I think things have been done this way on purpose, but that's just my 2c. |
Contributor
Author
Yeah, I thought about that too - it wasn't technically broken, but it did lead to errors being silently ignored, so in that sense it fixes the issue. |
0xSysR3ll
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes requests silently failing when Radarr/Sonarr are unreachable.
Requests are now marked as
FAILEDand notifications are sent to alert both users and admins.Additionally, this enables the
Retrybutton for failed requests, so admins can quickly resend them once the connection to Radarr/Sonarr has been restored.Screenshot (if UI-related)
To-Dos
pnpm buildpnpm i18n:extractIssues Fixed or Closed