Skip to content

Module structure cleanup #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Module structure cleanup #31

wants to merge 2 commits into from

Conversation

gibbz00
Copy link
Contributor

@gibbz00 gibbz00 commented Sep 13, 2024

Depends on #30

@gibbz00 gibbz00 mentioned this pull request Sep 14, 2024
Open
seffradev
seffradev approved these changes Sep 14, 2024
View reviewed changes
Copy link
Owner

@seffradev seffradev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, waiting for the fixes in #30 before accepting.

@seffradev
Copy link
Owner

Oh no, it needs to fix conflicts with the main branch :(

@gibbz00 have fun with like two commands :)

@gibbz00 gibbz00 force-pushed the module_cleanup branch 2 times, most recently from 0dbf790 to ddfe4e7 Compare September 14, 2024 16:40
@gibbz00 gibbz00 requested a review from seffradev September 14, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seffradev seffradev Awaiting requested review from seffradev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gibbz00 @seffradev