Skip to content

[STRATCONN-5657] - Add batch keys to webhook action destination #2878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

varadarajan-tw
Copy link
Contributor

@varadarajan-tw varadarajan-tw commented Apr 23, 2025

This PR adds a new hidden batch_keys mapping. This mapping controls how events are batched together. This PR in itself won't have any effect as it depends on https://github.com/segmentio/integrations-go/pull/449. The integrations-go changes are behind a flagon and we'll be doing a controlled rollout.

Testing doc - [ref]

Testing

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.92%. Comparing base (cf633f8) to head (f6504d3).

Files with missing lines Patch % Lines
...ctions/src/destinations/webhook-audiences/index.ts 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2878       +/-   ##
===========================================
+ Coverage   32.57%   77.92%   +45.35%     
===========================================
  Files          14     1047     +1033     
  Lines         703    19261    +18558     
  Branches      119     3750     +3631     
===========================================
+ Hits          229    15010    +14781     
- Misses        474     2927     +2453     
- Partials        0     1324     +1324     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@varadarajan-tw varadarajan-tw marked this pull request as ready for review April 23, 2025 17:39
@varadarajan-tw varadarajan-tw requested a review from a team as a code owner April 23, 2025 17:39
@varadarajan-tw varadarajan-tw force-pushed the add-batch-keys-webhook-destination branch from ba6ecf8 to f6504d3 Compare April 28, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant